Subject: [apps-discuss] Apps-team review of draft-ietf-dime-extended-naptr-06

From: Joseph Yee <[email-masked]>
Date: Sun, 24 Apr 2011 12:28:50 -0400

We have been selected as the Applications Area Review Team reviewer for this draft (for background on apps-review, please 
seehttp://www.apps.ietf.org/content/applications-area-review-team).

Please resolve these comments along with any other Last Call comments you may receive. Please wait for direction from your document shepherd or AD before posting a new version of the draft.

Document: draft-ietf-dime-extended-naptr-06

Title: Diameter S-NAPTR Usage

Reviewers: Julian Reschke, Joseph Yee

Review Date: April 23, 2011

Summary: This draft is almost ready for publication as Standard Track RFC but has a few issues that should be fixed before publication

Major Issues: 

     "app-protocol" is defined optional rather mandatory in current draft       
     This draft adopts the model from RFC3958, where app-protocol is optional. Not a Diameter myself, but I am under impression that this draft intends to make app-protocol mandatory. The previous model (RFC3588) always advertise the transport protocol (D2S or D2T).  If app-protocol is mandatory, add text (to Section 3, IMHO) to ensure it to readers.  If app-protocol is optional, please disregard this issue, but I would suggest to expand Section 5 (query procedure steps).

Minor Issues: 

     Section 3:
     iana-registered-service = aaa-service / ALPHA *31ALPHANUMSYM
     aaa-service             = "aaa+ap" appln-id
     appln-id                = DIGIT *DIGIT
                               ; Application identifier expressed as a
                               ; decimal integer.

1) Is "aaa+ap" case-insensitive? (That's the ABNF default for string literals)

2) Maybe "1*DIGIT" instead of "DIGIT *DIGIT"?

     iana-registered-protocol = aaa-protocol / ALPHA *31ALPHANUMSYM
     aaa-protocol             = "diameter." aaa-transport
     aaa-transport            = "tcp" / "sctp" / "tls.tcp"

Nits:
     None