Subject: [apps-discuss] APPSDIR review of draft-claise-export-application-info-in-ipfix-05

From: "Jiankang YAO" <[email-masked]>
Date: Fri, 20 Apr 2012 10:03:48 +0800

I have been selected as the Applications Area Directorate reviewer 
for this draft (for background on AppsDir, please see 
http://trac.tools.ietf.org/area/app/trac/wiki/ApplicationsAreaDirectorate ).

Please resolve these comments along with any other Last Call comments 
you may receive. Please wait for direction from your document 
shepherd or AD before posting a new version of the draft.

Document: draft-claise-export-application-info-in-ipfix-05
Title: Export of Application Information in IPFIX
Reviewer: Jiankang Yao
Review Date: April 20, 2012

Summary:  This document is almost ready for publication as a Informational RFC.

This draft specifies an extension to the IPFIX information model specified in [RFC5102] to export application
 information.

Minor issue:

In Section 6:

          6. Application Id Examples................................. 21
           6.1. Example 1: Layer 2 Protocol........................ 21
           6.2. Example 2: Standardized IANA Layer 3 Protocol...... 22
           6.3. Example 3: Proprietary Layer 3 Protocol............ 23
           6.4. Example 4: Standardized IANA Layer 4 Port.......... 25
           6.5. Example 4: Layer 7 Application..................... 26
           6.6. Example: port Obfuscation.......................... 28
           6.7. Example: Application Mapping Options Template...... 29
           6.8. Example: Attributes Values Options Template Record. 30

Comments : This section is all about examples, covering 10 pages. I suggest to move it to the appendix of this document since it does not specify anything.

Discussion issue:

 In section 2
     "
       Application could be defined at different OSI layers, from
      layer 2 to layer 7. For example: Link Layer Distribution
      Protocol (LLDP) [LLDP] is layer 2 application, ICMP is layer
      3 application [IANA-PROTO], HTTP is layer 4 application
      [IANA-PORTS], and skype is layer 7. "
   
Comments:  From my understanding, HTTP  is  a kind of layer 7 application based on OSI, but it can be identified in layer 4.
If my understanding is correct, I suggest to tune the text to the following:

    "
       Application could be identified at different OSI layers, from
      layer 2 to layer 7. For example: Link Layer Distribution
      Protocol (LLDP) [LLDP] can be identified in layer 2, ICMP is can be identified in layer 3
[IANA-PROTO], HTTP can be identified in layer 4  [IANA-PORTS], and skype can be identified in layer7. "

In the rest of document, it need to be tuned accordingly too.

Nits:

Section6.5. title:  Example 4: Layer 7 Application

Change it to "Example 5: Layer 7 Application" since section 6.4 title is " Example 4: Standardized IANA Layer 4 Port"?

Jiankang Yao