Subject: [apps-discuss] AppsDir review of draft-ietf-emu-chbind-14

From: Yoshiro YONEYA <[email-masked]>
Date: Mon, 16 Apr 2012 18:50:10 +0900

I have been selected as the Applications Area Directorate reviewer for 
this draft (for background on appsdir, please see  
http://trac.tools.ietf.org/area/app/trac/wiki/ApplicationsAreaDirectorate).

Please resolve these comments along with any other Last Call comments 
you may receive. Please wait for direction from your document shepherd 
or AD before posting a new version of the draft.

Document: draft-ietf-emu-chbind-14.txt
Title: Channel Binding Support for EAP Methods
Reviewer: Yoshiro Yoneya
Review Date: 16 April 2012
IETF Last Call Date: 29 March 2012
IESG Telechat Date: 26 April 2012
Summary: This draft is almost ready for publication as an Standards Track
         RFC but has a few issues that should be fixed before publication.

Major Issues:

  Section 5.1 [Page 13]
    Arrival order of i2 and i1 to the EAP server is not specified. 
    What happens if i1 arrives before i2 arrival?  What happens if i2 
    arrives but i1 never?  Latter case could be potential DoS attack 
    to the EAP server if the authenticator is malicious.

Minor Issues:

  Section 5.3 [Page 17]
    In description of NSID: The word "RADIUS" is the first appearance in 
    this document and it should have reference to RADIUS standard.

  Section 5.3.3 [Page 18]
    The word "AVP" is the first appearance in this document and its full 
    wording should be dentoted here.

  Section 7 [Page 20]
    The word "TLV" is the first appearance in this document and its full 
    wording should be denoted here.

Nits:

  Section 3 [Page 6]
    First bullet: virtual Lads (VLANs) => virtual LANs (VLANs)

  Section 3 [Page 7]
    Second bullet: The EAP GSS-API mechanism [I-D.ietf-abfab-gss-eap] mechanism =>
                   The EAP GSS-API mechanism [I-D.ietf-abfab-gss-eap]

  Section 7.2 [Page 21]
    "Type" in packet format and "The code" in last paragraph seems to 
    be the same thing, but the name is differ.  Should use the same word.

  Section 12 [Page 27]
    Sam hartman's => Sam Hartman's

-- 
Yoshiro YONEYA <[email-masked]>