
From nobody Wed Nov 18 23:28:06 2020
Return-Path: <barryleiba@gmail.com>
X-Original-To: cdni@ietfa.amsl.com
Delivered-To: cdni@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A45573A110C; Wed, 18 Nov 2020 23:28:04 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.398
X-Spam-Level: 
X-Spam-Status: No, score=-1.398 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yZfNVwoyFm5p; Wed, 18 Nov 2020 23:28:03 -0800 (PST)
Received: from mail-vk1-f177.google.com (mail-vk1-f177.google.com [209.85.221.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DE66A3A1109; Wed, 18 Nov 2020 23:27:59 -0800 (PST)
Received: by mail-vk1-f177.google.com with SMTP id d191so1119684vka.13; Wed, 18 Nov 2020 23:27:59 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=tzzFs6dr87hjLFM6i+3tX9KmacGKnezWCYnwWb+vlsQ=; b=ROpE1pL4I/dcwvGewqx76ETIocVAS3QCKM39ppDe7ZCf8GkVVh9qBYJj7Zbhn4bual 7YzBUXUB7LZ7GKRRV8T36zYC82PrIk9bbTBPEIu2nWay3M2ePnGFiPo4OgocTbZlkva9 3Gzog0p+9HOOS0PLIJ1wY4LWEydYoA67QUt6fRfakYipf1SD7VHBOCKdOIYJUb9Rr8Nb nRDkueZ45XjrpkuFTdxTTXvf8i+euuEXWDBPkNeu9OQquTTZxXJKsuWJ28ziPuUkYH/f rZRHaJptEYo96wqFPaKFRXFKuojTooVlGc8BZh1FlwdWUJDMS+z53EkwnFVwGBnob53D IcKg==
X-Gm-Message-State: AOAM5324K2VvSG+OuXi/YlT2K+LI8F78APLYKMQRdouGYZHEB83dxyaV 9riRjB45W/0BR1LvgQOANAkb+ZylyRd309Lq2yQvKk4Use4=
X-Google-Smtp-Source: ABdhPJzyyt1ydzozifBybG+n1mbQkbaea14X5xinMksN8I7RcZe6U/7IDJBNf3KghkKV5ZNqUQQWnN2mf5v6itc5SMc=
X-Received: by 2002:a1f:2f48:: with SMTP id v69mr7178810vkv.23.1605770878651;  Wed, 18 Nov 2020 23:27:58 -0800 (PST)
MIME-Version: 1.0
References: <CALaySJJkZiRYx16cUYDtD2LU+3qAKMtMB_qY7cwkpQnWMnVMpg@mail.gmail.com> <CALaySJL9R-cQHogD+psMD0pd6HpB+3y4o5KqC=b1i63+OOzYtw@mail.gmail.com> <22DF373A-A2C4-447B-AD47-30CD04476245@apple.com>
In-Reply-To: <22DF373A-A2C4-447B-AD47-30CD04476245@apple.com>
From: Barry Leiba <barryleiba@computer.org>
Date: Thu, 19 Nov 2020 02:27:47 -0500
Message-ID: <CALaySJK-Sq85_EC-fBj8qKWD94HQML6dO76Eh2rbLpikdtiZtw@mail.gmail.com>
To: Phil Sorber <sorber@apple.com>
Cc: "draft-ietf-cdni-uri-signing.all@ietf.org" <draft-ietf-cdni-uri-signing.all@ietf.org>,  "<cdni@ietf.org>" <cdni@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/cdni/oDaVhx7b48wpdM4GIuR67WZEErc>
Subject: Re: [CDNi] AD review of draft-ietf-cdni-uri-signing-19
X-BeenThere: cdni@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "This list is to discuss issues associated with the Interconnection of Content Delivery Networks \(CDNs\)" <cdni.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cdni>, <mailto:cdni-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cdni/>
List-Post: <mailto:cdni@ietf.org>
List-Help: <mailto:cdni-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cdni>, <mailto:cdni-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Nov 2020 07:28:05 -0000

Hi, Phil; I'm following up again: it's been almost 4 more months,
making it 8 months since my AD review.

Barry

On Thu, Jul 23, 2020 at 5:02 PM Phil Sorber <sorber@apple.com> wrote:
>
> Hi,
>
> Sorry for the long delay. I started working through your requested change=
s, but haven=E2=80=99t had time to finish. Things have been a little weird=
=E2=80=A6
>
> Thank you for following up. I will try to get back to this very shortly.
>
> Thanks.
>
> > On Jul 23, 2020, at 14:59, Barry Leiba <barryleiba@computer.org> wrote:
> >
> > What's the status of this document?  It's been about four months since
> > my AD review, in "revised I-D needed" substate.
> >
> > Barry
> >
> > On Fri, Mar 13, 2020 at 1:05 AM Barry Leiba <barryleiba@computer.org> w=
rote:
> >>
> >> Here is my AD review of draft-ietf-cdni-uri-signing-19.  My apologies =
for taking a couple of weeks to get to this: the IESG has, as you can imagi=
ne, been swamped with both heavy telechat schedules because of the impendin=
g AD changeover and unexpected craziness with IETF 107 planning and decisio=
ns related to the meeting cancellation.
> >>
> >> Kevin, thanks so much for a very thorough and excellent shepherd write=
up!
> >>
> >> A couple of these comments are substantive, so I would like to discuss=
 and resolve them before last call.  I=E2=80=99m going to set the draft=E2=
=80=99s substate to =E2=80=9Crevised I-D needed=E2=80=9D.
> >>
> >> Please expand =E2=80=9CCDNI=E2=80=9D in the abstract... and possibly i=
n the title as well, though you could wait for the RPC to do that if you pr=
efer.  Please also fully expand =E2=80=9CCDN=E2=80=9D on its first use in t=
he introduction.
> >>
> >> Please replace =E2=80=9CUA=E2=80=9D in the abstract with =E2=80=9Cuser=
 agent=E2=80=9D.
> >>
> >>   This document uses the terminology defined in the CDNI Problem
> >>   Statement [RFC6707].
> >>
> >> I believe that terminology definitions are normative references, so I =
believe this makes 6707 normative.  Happily, normative downrefs such as thi=
s are accepted now, so please make the reference normative and I will make =
sure it=E2=80=99s called out in the last call notice.
> >>
> >> =E2=80=94 Section 1.3 =E2=80=94
> >>
> >>   With symmetric keys, the same key is
> >>   used by both the signing entity for signing the URI as well as by th=
e
> >>   verifying entity for verifying the Signed URI.
> >>
> >> Nit: Think of =E2=80=9Cboth=E2=80=9D as an open parenthesis (and the e=
nd of he sentence as the closing one here).  The first =E2=80=9Cby=E2=80=9D=
 is outside the parens (before =E2=80=9Cboth=E2=80=9D), but the second is i=
nside, and that=E2=80=99s not parallel.  Make it either =E2=80=9Cby both th=
e signing entity [...] and the verifying entity=E2=80=9D or =E2=80=9Cboth b=
y the signing entity [...] and by the verifying entity=E2=80=9D.
> >>
> >>   distributed openly (because they cannot be used to sign URIs) and
> >>   private keys are kept secret by the URI signer.
> >>
> >> I would say =E2=80=9Cand the corresponding private keys=E2=80=9D.
> >>
> >> =E2=80=94 Section 1.4 =E2=80=94
> >>
> >>   While the URI signing method defined in this document was primarily
> >>   created for the purpose of allowing URI Signing in CDNI scenarios,
> >>   i.e., between a uCDN and a dCDN, there is nothing in the defined URI
> >>   Signing method that precludes it from being used in a non-CDNI
> >>
> >> As you see here, you capitalize =E2=80=9CURI Signing=E2=80=9D inconsis=
tently,even in this one paragraph.  Please check the document for consisten=
cy in the capitalization: pick one and use it throughout.
> >>
> >> =E2=80=94 Section 2 =E2=80=94
> >>
> >>   HTTP or HTTPS URI [RFC7230] (Section 2.7).
> >>
> >> This is a quirk of the tools and not a fault in the draft, but this re=
sults in the html version having a clickable link to RFC 7230, and then ano=
ther clickable link to Section 2.7 of this document (which, of course, isn=
=E2=80=99t there).  I think if you change this to =E2=80=9CHTTP or HTTPS UR=
I (see [RFC7230] Section 2.7)=E2=80=9D the generated link will work better.
> >>
> >>   o  a reserved character (as defined in [RFC3986] Section 2.2),
> >>
> >> Any reserved character?  And the three reserved characters in bullets =
1, 3, and 5 can be any three different ones?  I think I know what you mean,=
 but it seems that an implementer who doesn=E2=80=99t could go quite wrong.=
  Maybe some more words along with these bullets would be better?
> >>
> >> [For example, in the URI < http://example.com/content?sign=3Djwtdatahe=
re&other >, I think that if I strictly implement what you have here I would=
 interpret =E2=80=9Cexample.com/=E2=80=9D as the attribute name (because =
=E2=80=9C/=E2=80=9C is a reserved character), =E2=80=9Ccontent=E2=80=9D as =
the JWT package, and =E2=80=9C?=E2=80=9D as the terminating special charact=
er.  But you=E2=80=99re looking for something more like =E2=80=9Csign=E2=80=
=9D as the attribute name and =E2=80=9Cjwtdatahere=E2=80=9D as the JWT pack=
age, yes?]
> >>
> >> Also, I don=E2=80=99t see any examples in the draft of a Signed URI, a=
nd I think an example or two here of a couple of variations would also help=
.
> >>
> >> =E2=80=94 Section 2.1 =E2=80=94
> >> Several of the subsections that deal with time values repeat this text=
 exactly:
> >>
> >>   Note: The time
> >>   on the entities that generate and verify the signed URI SHOULD be in
> >>   sync.  In the CDNI case, this means that CSP, uCDN, and dCDN servers
> >>   need to be time-synchronized.  It is RECOMMENDED to use NTP [RFC5905=
]
> >>   for time synchronization.
> >>
> >> I suggest cleaning this up by moving that note up here to the end of S=
ection 2.1, saying, =E2=80=9CNote: When claims related to time are used, th=
e time on the entities...=E2=80=9D
> >>
> >> =E2=80=94 Section 2.1.7 =E2=80=94
> >>
> >>   previously seen the nonce used in a request for the same content
> >>
> >> This is the only spot where you don=E2=80=99t capitalize =E2=80=9CNonc=
e=E2=80=9D.
> >>
> >> =E2=80=94 Section 2.1.9 =E2=80=94
> >>
> >>   This claim MUST be understood and processed by
> >>   all implementations.
> >>
> >> Section 2.1 already said this about all claims, so why say it here abo=
ut this one in particular?
> >>
> >> =E2=80=94 Section 2.1.10 =E2=80=94
> >>
> >>   Client IP (cdniip) [optional] - The Client IP (cdniip) claim hold an
> >>
> >> Nit: =E2=80=9Cholds=E2=80=9D
> >>
> >> =E2=80=94 Section 2.1.15 =E2=80=94
> >>
> >>   The URI Container (cdniuc) claim takes one of the following forms
> >>
> >> This is the only claim definition that doesn=E2=80=99t say =E2=80=9C[o=
ptional]=E2=80=9D.  Should it?
> >>
> >> =E2=80=94 Section 3.2 =E2=80=94
> >>
> >>   the following section defines a mechanism using HTTP Cookies
> >>
> >> Please use a specific section xref instead.
> >>
> >> =E2=80=94 Section 6.7 =E2=80=94
> >> Thanks for including advice to the experts.
> >>
> >>   Expert Reviewers should be empowered to pass judgements
> >>   as they see fit
> >>
> >> This is very vague and, to me, implies more capriciousness than I thin=
k you really intend.  Can you come up with another way to word this that gi=
ves a bit more guidance?  What sorts of judgments are they likely to make?
> >>
> >> =E2=80=94 Section 7 =E2=80=94
> >>
> >>      seconds to prevent a sudden network issues from denying legitimat=
e
> >>
> >> Nit: either remove =E2=80=9Ca=E2=80=9D or make it =E2=80=9Cissue=E2=80=
=9D
>

