Subject: Re: [Dime] New Version Notification for draft-korhonen-dime-ovl-00.txt

From: jouni korhonen <[email-masked]>
Date: Sat, 3 Nov 2012 20:44:53 +0200

Hi,

Thanks for the review. See my comments inline.

On Nov 3, 2012, at 6:32 PM, Ivan Skytte Jørgensen wrote:

>> 4.5. OC-Algorithm AVP
>>  Drop (0x00000001)
>> 
>>     Messages are plain dropped.  It is RECOMMENDED to drop messages
>>     selectively based, for example, on application priorities.  This
>>     is the default algorithm.
> 
> By "drop" don't you mean "not send" ?

Correct.

>> 4.9. OC-Sending-Rate AVP
>> 
>>  The OC-Sending-Rate (AVP Code TBD11) is of type Float32 and tells the
>>  the maximum Diameter message sending rate per second the sender of
>>  this information wishes to receive Diameter messages.  Only positive
>>  values are valid.  A value of zero (0.0) of the absence of this AVP
>>  means the information sender has no specific rate preference.
> 
> The special treatment of the value 0.0 sounds a bit ugly. Are there any diamter stacks that would have difficulties in simply not including the AVP?

Good point. THat could easily be defined as a default behavior
when the AVP is absent.

>>  If a DOCA server finds the sending rate value proposed by a DOCA
>>  client too big (i.e. too frequent periodic messages), then the DOCA
>>  server MUST send the DOCA-Report-Answer indicating an error and set
>>  the Result-Code to the DIAMETER_RATE_TOO_BIG value.
> 
> Wouldn't it be better if the DOCA client send a proposed rate, and the server responded with an accepted rate ?

Could be. I'll think about it.

- JOuni