
From r.hieber@tu-bs.de  Tue Apr 22 09:50:37 2014
Return-Path: <r.hieber@tu-bs.de>
X-Original-To: dtn-users@ietfa.amsl.com
Delivered-To: dtn-users@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ED4361A06A4 for <dtn-users@ietfa.amsl.com>; Tue, 22 Apr 2014 09:50:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.178
X-Spam-Level: 
X-Spam-Status: No, score=0.178 tagged_above=-999 required=5 tests=[BAYES_50=0.8, HELO_EQ_DE=0.35, RCVD_IN_DNSWL_LOW=-0.7, RP_MATCHES_RCVD=-0.272] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6RNmlF80tXU2 for <dtn-users@ietfa.amsl.com>; Tue, 22 Apr 2014 09:50:32 -0700 (PDT)
Received: from mailfront1.rz.tu-bs.de (mailfront1.rz.tu-bs.de [134.169.12.132]) by ietfa.amsl.com (Postfix) with ESMTP id 572FB1A04D2 for <dtn-users@irtf.org>; Tue, 22 Apr 2014 09:50:32 -0700 (PDT)
Received: from [134.169.34.1] (account y0033607@tu-braunschweig.de HELO [10.1.0.123]) by tu-braunschweig.de (CommuniGate Pro SMTP 6.0.8) with ESMTPA id 42775369 for dtn-users@irtf.org; Tue, 22 Apr 2014 18:50:25 +0200
Message-ID: <53569DCA.5000208@tu-bs.de>
Date: Tue, 22 Apr 2014 18:50:18 +0200
From: Roland Hieber <r.hieber@tu-bs.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.4.0
MIME-Version: 1.0
To: dtn-users@irtf.org
X-Enigmail-Version: 1.6
Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="j9L3s95DKcwdShd5lK79ANfuO9xQn2qSM"
Archived-At: http://mailarchive.ietf.org/arch/msg/dtn-users/MDQfZdISTCSS-to5m1pzWnGSR8A
X-Mailman-Approved-At: Thu, 01 May 2014 08:06:02 -0700
Subject: [dtn-users] [PATCH] Compiling oasys with readline 6.3
X-BeenThere: dtn-users@irtf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "The Delay-Tolerant Networking Research Group \(DTNRG\) - Users." <dtn-users.irtf.org>
List-Unsubscribe: <https://www.irtf.org/mailman/options/dtn-users>, <mailto:dtn-users-request@irtf.org?subject=unsubscribe>
List-Archive: <http://www.irtf.org/mail-archive/web/dtn-users/>
List-Post: <mailto:dtn-users@irtf.org>
List-Help: <mailto:dtn-users-request@irtf.org?subject=help>
List-Subscribe: <https://www.irtf.org/mailman/listinfo/dtn-users>, <mailto:dtn-users-request@irtf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Apr 2014 16:51:53 -0000

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--j9L3s95DKcwdShd5lK79ANfuO9xQn2qSM
Content-Type: multipart/mixed;
 boundary="------------060301030701080702060906"

This is a multi-part message in MIME format.
--------------060301030701080702060906
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi,

I tried to compile oasys on my Debian testing, and I got the following
error:

gcc  -g -fno-inline  -fPIC -DPIC -MMD -MP -MT "tclcmd/tclreadline.o
tclcmd/tclreadline.E"  -DHAVE_CONFIG_H -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=3D64 -I. -I. -I/home/rohieb/Projects/dtn/oasys -I./ex=
t
-I/usr/include/tcl8.4  -w -c tclcmd/tclreadline.c -o tclcmd/tclreadline.o=

tclcmd/tclreadline.c: In function =E2=80=98TclReadlineInitialize=E2=80=99=
:
tclcmd/tclreadline.c:702:41: error: =E2=80=98CPPFunction=E2=80=99 undecla=
red (first use
in this function)
     rl_attempted_completion_function =3D (CPPFunction *)
TclReadlineCompletion;

Apparently [0], CPPFunction got renamed in readline 6.3. Unfortunately,
I cannot log in to SourceForge right now, so please see the attached
patch (based on hg 675b978f435b), which works for me. (Well, oasys
compiles, but when building the test suite, I get different errors about
memcpy not being found, so I cannot test it right now. Anyway, this
should be a trivial change.)

[0]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D741767#19

 - Roland

--------------060301030701080702060906
Content-Type: text/x-patch;
 name="readline6.3.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
 filename="readline6.3.patch"

diff -r 675b978f435b tclcmd/tclreadline.c
--- a/tclcmd/tclreadline.c	Mon Feb 18 09:50:19 2013 +0000
+++ b/tclcmd/tclreadline.c	Tue Apr 22 18:45:25 2014 +0200
@@ -699,7 +699,7 @@
      * directory. If this failes, this
      * is *not* an error.
      */
-    rl_attempted_completion_function =3D (CPPFunction *) TclReadlineComp=
letion;
+    rl_attempted_completion_function =3D (rl_completion_func_t *) TclRea=
dlineCompletion;
     if (read_history(historyfile)) {
 	if (write_history(historyfile)) {
 	    Tcl_AppendResult (interp, "warning: `",

--------------060301030701080702060906--

--j9L3s95DKcwdShd5lK79ANfuO9xQn2qSM
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBCgAGBQJTVp3KAAoJEMOZylE6vjlSNKQIAIL8loWnnJRbwMqpDC1JsvgJ
oVmMiMxUlxLZzG7JmBpYlKLbb7ltWwNc8NWk7xX/vFcGfc/FTwpkTpU9eYScndT3
2Ibzzcfp6zvxbifPamxMf1vWDpXjrSQVIGoCFiroUFyWjuMLqFezVRetWlRRHOLf
K7s0/thKufMkayOz5QnFoAEbXeKMY6zNYzEBBgWsHJO9hJFlBxcucwr8guimadcj
8UQVVxCBkb/+QvCsrnhgY1uxD6u9RW0/q+bSnDq1qaDv9y05OiAPFYc4y3ShrWzR
pLFsZPy1g1S8WVeu6LmSj3QmTuCBHSOYrgSwi6dHWaz5qxgkfTM5OWkirDDwSEk=
=p6V1
-----END PGP SIGNATURE-----

--j9L3s95DKcwdShd5lK79ANfuO9xQn2qSM--

