Subject: [quicwg/base-drafts] Awkward text in "Sending Probe Packets" (#2493)

From: Lars Eggert <[email-masked]>
Date: Thu, 28 Feb 2019 16:57:08 -0800

As discussed with @janaiyengar, 6.2.2.2 is awkward, because in the first paragraph it says
```
   When a PTO timer expires, the sender MUST send one ack-eliciting
   packet as a probe.
```
And then the very last paragraph changes that by saying
```
   When a PTO timer expires, new or previously-sent data may not be
   available to send and packets may still be in flight.  A sender can
   be blocked from sending new data in the future if packets are left in
   flight.  Under these conditions, a sender SHOULD mark any packets
   still in flight as lost.
```
What is super unclear is that the final paragraph apparently means to imply that when there is no new or unACKed data to send, *nothing* should be send, i.e., it invalidates the SHOULD in the first paragraph.

Related to that, the pseudo code still uses `SendTwoPackets()`, which is also inaccurate, since it's really "at least one (unless you don't have new or unACKed data) but can also send two". Good luck finding a good name for that function :-)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2493