Subject: Re: [quicwg/base-drafts] Send after receiving an ACK (#3047)

From: Martin Thomson <[email-masked]>
Date: Mon, 02 Dec 2019 19:18:11 -0800

martinthomson commented on this pull request.

Would it fair up-level and ask whether the ACK handler should trigger any sending?  I realize that the disagreement appears to be about whether this is advocating for a burst send, but it seems to me that the bigger question is where to attach sending logic to the pseudocode.

>    newly_acked_packets = DetermineNewlyAckedPackets(ack, pn_space)
+  // Nothing to do if there are no newly acked packets.

This change looks like a regression, or it is as at least unrelated: the intent before was to comment about the call to `DetermineNewlyAckedPackets()` and the use of the returned value.  I think that's still the right way to frame this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3047#pullrequestreview-325874270